-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat:] Add Log tailing #610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not handling the case when the server is stopped and started. I expect the log following to either drop or switch to the newly started server instance.
lint Co-authored-by: Gorkem Ercan <[email protected]>
I can drop the logs when server is stopped. Do we currently allow 2 development servers running at once? |
Only one instance is allowed to run. |
@gorkem shows a server stopped message when the server is stopped and resolved conversations :). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized my inline comments are not uploaded to GH trying again
Co-authored-by: Angel Misevski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @srikary12!
Description
Adds log tailing capability
Linked issues
#591