Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat:] Add Log tailing #610

Merged
merged 8 commits into from
Dec 16, 2024
Merged

[feat:] Add Log tailing #610

merged 8 commits into from
Dec 16, 2024

Conversation

srikary12
Copy link
Contributor

Description

Adds log tailing capability

Linked issues

#591

@srikary12 srikary12 marked this pull request as ready for review November 8, 2024 11:39
Copy link
Contributor

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not handling the case when the server is stopped and started. I expect the log following to either drop or switch to the newly started server instance.

pkg/cmd/dev/cmd.go Outdated Show resolved Hide resolved
pkg/lib/harness/llm-harness.go Outdated Show resolved Hide resolved
pkg/lib/harness/llm-harness.go Outdated Show resolved Hide resolved
pkg/lib/harness/llm-harness.go Outdated Show resolved Hide resolved
@srikary12
Copy link
Contributor Author

srikary12 commented Nov 9, 2024

I can drop the logs when server is stopped.

Do we currently allow 2 development servers running at once?

@gorkem
Copy link
Contributor

gorkem commented Nov 9, 2024

I can drop the logs when server is stopped.

Do we currently allow 2 development servers running at once?

Only one instance is allowed to run.

@srikary12 srikary12 requested a review from gorkem November 10, 2024 16:54
@srikary12
Copy link
Contributor Author

srikary12 commented Nov 10, 2024

@gorkem shows a server stopped message when the server is stopped and resolved conversations :).

@srikary12 srikary12 requested a review from amisevsk November 13, 2024 06:03
Copy link
Contributor

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realized my inline comments are not uploaded to GH trying again

pkg/lib/harness/llm-harness.go Outdated Show resolved Hide resolved
@srikary12 srikary12 requested a review from gorkem November 19, 2024 15:59
pkg/cmd/dev/cmd.go Outdated Show resolved Hide resolved
pkg/lib/harness/llm-harness.go Outdated Show resolved Hide resolved
@srikary12 srikary12 requested a review from amisevsk November 20, 2024 07:39
Co-authored-by: Angel Misevski <[email protected]>
pkg/lib/harness/llm-harness.go Outdated Show resolved Hide resolved
pkg/lib/harness/llm-harness.go Outdated Show resolved Hide resolved
@srikary12 srikary12 marked this pull request as draft December 11, 2024 05:39
@srikary12 srikary12 marked this pull request as ready for review December 11, 2024 05:50
@srikary12 srikary12 requested a review from amisevsk December 11, 2024 05:50
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks @srikary12!

@amisevsk amisevsk merged commit e7a2411 into jozu-ai:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants